100% tests coverage for web5/crypto
#215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adam4leos
commented
Sep 12, 2023
adam4leos
commented
adam4leos
requested review from
frankhinek,
csuwildcat and
mistermoe
as code owners
adam4leos
commented
Sep 12, 2023
| @@ -863,7 +863,7 @@ export class Jose { | |||
| const jose = multicodecToJoseMapping[lookupKey]; | |||
|
|
|||
| if (jose === undefined) { | |||
| throw new Error(`Unsupported Multicodec to JOSE conversion: '${options.name ?? options.code}'`); | |||
There was a problem hiding this comment.
this is unreachable;
we can't hit this line with undefined code AND name, as undefined code would throw in getNameFromCode with undefined name
Removed to reach 100% tests coverage, as it's not possible to cover unreachable edge case...
There was a problem hiding this comment.
Appreciate the clarification
Codecov Report
@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 89.42% 90.78% +1.35%
==========================================
Files 64 67 +3
Lines 12399 12828 +429
Branches 1188 1268 +80
==========================================
+ Hits 11088 11646 +558
+ Misses 1291 1159 -132
- Partials 20 23 +3
|
frankhinek
approved these changes
Sep 14, 2023
| @@ -863,7 +863,7 @@ export class Jose { | |||
| const jose = multicodecToJoseMapping[lookupKey]; | |||
|
|
|||
| if (jose === undefined) { | |||
| throw new Error(`Unsupported Multicodec to JOSE conversion: '${options.name ?? options.code}'`); | |||
There was a problem hiding this comment.
Appreciate the clarification
finn-tbd
pushed a commit
that referenced
this pull request
Sep 18, 2023
* jose file covered * remove unreachable condition
andorsk
pushed a commit
to modernfoundry/web5-js
that referenced
this pull request
Sep 28, 2023
* jose file covered * remove unreachable condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.